Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] Remove unused mixins from the codebase #703

Merged
merged 2 commits into from
Jul 22, 2024
Merged

[cleanup] Remove unused mixins from the codebase #703

merged 2 commits into from
Jul 22, 2024

Conversation

bahiirwa
Copy link
Contributor

@bahiirwa bahiirwa commented Apr 10, 2024 •
edited
Loading

  • Remove unused mixins from the codebase.
  • Use the autoprefixer in the build process. Remove mixins made obsolute. We have an autoprefixer which makes the build process more efficient in managing future browser support and deprecations.

DanieleAlessandra
DanieleAlessandra approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@DanieleAlessandra DanieleAlessandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the modifications to the SCSS files and observed that the resulting CSS is essentially unchanged from before. Initially, I had reservations about the continued necessity of maintaining vendor prefixes in 2024. However, I believe that we should continue to support them for a while. Therefore, I am satisfied with the current state of the changes.

@bahiirwa bahiirwa requested a review from swashata May 5, 2024 15:46
@bahiirwa @swashata
[cleanup] Remove unused mixins from the codebase. The autoprefixer in…
557b0f9 
… the build process makes some of the rules in the mixins obsolute.
@swashata
Copy link
Contributor

I have reviewed the modifications to the SCSS files and observed that the resulting CSS is essentially unchanged from before. Initially, I had reservations about the continued necessity of maintaining vendor prefixes in 2024. However, I believe that we should continue to support them for a while. Therefore, I am satisfied with the current state of the changes.

Thanks for the review @DanieleAlessandra, we already have POSTCSS which adds the prefix if needed.

swashata
swashata approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@swashata swashata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swashata swashata merged commit c0c2270 into develop Jul 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashata swashata swashata approved these changes

@DanieleAlessandra DanieleAlessandra DanieleAlessandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bahiirwa @swashata @DanieleAlessandra